Skip to content

Conversation

@threefjefff
Copy link
Collaborator

Describe your changes

  • Fix unescapableCommand triggering on every arrow down press within the Snippet (e.g. in the a central language block, pressing down would cause a blank space despite not being at the end of the Snippet)
  • Run unescapableCommand checks on up arrows too (e.g. you should be able to move above a snippet with the cursors)
  • Allow External Plugins commands to override pre-definied editor commands
    • Use the ability to override editor commands to swallow commands that are nonsensical for Snippets, and cause breaking changes to happen (e.g. inserting a line-rule in the middle of the Snippet)

@changeset-bot
Copy link

changeset-bot bot commented Apr 30, 2025

🦋 Changeset detected

Latest commit: 64de985

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@stackoverflow/stacks-editor Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Apr 30, 2025

Deploy Preview for stacks-editor ready!

Name Link
🔨 Latest commit de22580
🔍 Latest deploy log https://app.netlify.com/sites/stacks-editor/deploys/68122aeb7a2c7800075aa911
😎 Deploy Preview https://deploy-preview-437--stacks-editor.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Apr 30, 2025

Deploy Preview for stacks-editor ready!

Name Link
🔨 Latest commit 9578ffb
🔍 Latest deploy log https://app.netlify.com/sites/stacks-editor/deploys/68122b1b7375a20008c8090b
😎 Deploy Preview https://deploy-preview-437--stacks-editor.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Apr 30, 2025

Deploy Preview for stacks-editor ready!

Name Link
🔨 Latest commit 64de985
🔍 Latest deploy log https://app.netlify.com/sites/stacks-editor/deploys/68132f7939d5060008e54c5e
😎 Deploy Preview https://deploy-preview-437--stacks-editor.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@alizaberger alizaberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and works well!

Co-authored-by: Aliza Berger <aberger@stackoverflow.com>
@threefjefff threefjefff merged commit 48dc5be into main May 1, 2025
5 checks passed
@threefjefff threefjefff deleted the jsmb/content-before-snippet branch May 1, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants